Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CRWA success message #1373

Merged
merged 4 commits into from
Oct 19, 2020
Merged

update CRWA success message #1373

merged 4 commits into from
Oct 19, 2020

Conversation

robobunny
Copy link
Contributor

Work in progress for issue #909

Screenshot from 2020-10-16 14-05-40

Changes I made

  • Added the link to the tutorial
  • Changed the link to the newsletter
    • Note: this link doesn't work yet, I submitted a PR on the .com (See Issue 418)
  • Minor changes to the verbiage to unify voice

Changes I didn't make

Because it seemed like too much tinkering for my first PR and because it's not obvious how to proceed:

  • Didn't change the text about yarn rw dev
  • Didn't add a list of CLI commands
  • git init && git add . && git commit -m "initial commit"
    • I couldn't tell if @thedavidprice is suggesting to add that to this success message or to add that to the code so it automatically does that, like create-react-app does

@robobunny robobunny changed the title change newsletter link, add tutorial link update CRWA success message Oct 16, 2020
@Tobbe
Copy link
Member

Tobbe commented Oct 16, 2020

@robobunny That looks great! I love it ♥ Thanks for submitting this PR :)

@peterp
Copy link
Contributor

peterp commented Oct 18, 2020

@robobunny It looks great, let me know when it's ready for review 👍

@robobunny
Copy link
Contributor Author

@peterp Sorry I don't know what to do ... do I just tell you? It's ready for review

@Tobbe Tobbe merged commit 998eb60 into redwoodjs:main Oct 19, 2020
@Tobbe
Copy link
Member

Tobbe commented Oct 19, 2020

@robobunny Thanks for your contribution. Your changes will make for a better experience for all future CRWA users 👍

@robobunny
Copy link
Contributor Author

@Tobbe: Pleasure! My first ever OSS contribution! I love redwood so much and the community is awesome. Great work!

@thedavidprice
Copy link
Contributor

My first ever OSS contribution! I love redwood so much and the community is awesome. Great work!

Well, this is just brilliant all around! The community is glad to have you be a part of it 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants