Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Update cell tests to just test that nothing is thrown #1397

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Proposal: Update cell tests to just test that nothing is thrown #1397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92a7d1a
Update cell tests to just test that nothing is thrown
cannikin Oct 23, 2020
d6c0378
Adds comment about starting to write your own tests
cannikin Oct 26, 2020
8991d51
Merge branch 'main' into rc-cell-tests
cannikin Oct 26, 2020
e0af041
Update tests for generated test file
cannikin Oct 26, 2020
7a6c79d
More test updates
cannikin Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions packages/cli/src/commands/generate/cell/__tests__/fixtures/camelCaseWordCell.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ import { standard } from './UserProfileCell.mock'

describe('UserProfileCell', () => {
test('Loading renders successfully', () => {
render(<Loading />)
// Use screen.debug() to see output
expect(screen.getByText('Loading...')).toBeInTheDocument()
expect(() => {
render(<Loading />)
}).not.toThrow()
})

test('Empty renders successfully', async () => {
render(<Empty />)
expect(screen.getByText('Empty')).toBeInTheDocument()
expect(() => {
render(<Empty />)
}).not.toThrow()
})

test('Failure renders successfully', async () => {
render(<Failure error={new Error('Oh no')} />)
expect(screen.getByText(/Oh no/i)).toBeInTheDocument()
expect(() => {
render(<Failure error={new Error('Oh no')} />)
}).not.toThrow()
})

// When you're ready to test the actual output of your component render
// you could test that, for example, certain text is present:
//
// expect(screen.getByText('Hello, world')).toBeInTheDocument()

test('Success renders successfully', async () => {
render(<Success userProfile={standard().userProfile} />)
expect(screen.getByText(/42/i)).toBeInTheDocument()
expect(() => {
render(<Success userProfile={standard().userProfile} />)
}).not.toThrow()
})
})
26 changes: 17 additions & 9 deletions packages/cli/src/commands/generate/cell/__tests__/fixtures/kebabCaseWordCell.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ import { standard } from './UserProfileCell.mock'

describe('UserProfileCell', () => {
test('Loading renders successfully', () => {
render(<Loading />)
// Use screen.debug() to see output
expect(screen.getByText('Loading...')).toBeInTheDocument()
expect(() => {
render(<Loading />)
}).not.toThrow()
})

test('Empty renders successfully', async () => {
render(<Empty />)
expect(screen.getByText('Empty')).toBeInTheDocument()
expect(() => {
render(<Empty />)
}).not.toThrow()
})

test('Failure renders successfully', async () => {
render(<Failure error={new Error('Oh no')} />)
expect(screen.getByText(/Oh no/i)).toBeInTheDocument()
expect(() => {
render(<Failure error={new Error('Oh no')} />)
}).not.toThrow()
})

// When you're ready to test the actual output of your component render
// you could test that, for example, certain text is present:
//
// expect(screen.getByText('Hello, world')).toBeInTheDocument()

test('Success renders successfully', async () => {
render(<Success userProfile={standard().userProfile} />)
expect(screen.getByText(/42/i)).toBeInTheDocument()
expect(() => {
render(<Success userProfile={standard().userProfile} />)
}).not.toThrow()
})
})
26 changes: 17 additions & 9 deletions packages/cli/src/commands/generate/cell/__tests__/fixtures/multiWordCell.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ import { standard } from './UserProfileCell.mock'

describe('UserProfileCell', () => {
test('Loading renders successfully', () => {
render(<Loading />)
// Use screen.debug() to see output
expect(screen.getByText('Loading...')).toBeInTheDocument()
expect(() => {
render(<Loading />)
}).not.toThrow()
})

test('Empty renders successfully', async () => {
render(<Empty />)
expect(screen.getByText('Empty')).toBeInTheDocument()
expect(() => {
render(<Empty />)
}).not.toThrow()
})

test('Failure renders successfully', async () => {
render(<Failure error={new Error('Oh no')} />)
expect(screen.getByText(/Oh no/i)).toBeInTheDocument()
expect(() => {
render(<Failure error={new Error('Oh no')} />)
}).not.toThrow()
})

// When you're ready to test the actual output of your component render
// you could test that, for example, certain text is present:
//
// expect(screen.getByText('Hello, world')).toBeInTheDocument()

test('Success renders successfully', async () => {
render(<Success userProfile={standard().userProfile} />)
expect(screen.getByText(/42/i)).toBeInTheDocument()
expect(() => {
render(<Success userProfile={standard().userProfile} />)
}).not.toThrow()
})
})
26 changes: 17 additions & 9 deletions packages/cli/src/commands/generate/cell/__tests__/fixtures/singleWordCell.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ import { standard } from './UserCell.mock'

describe('UserCell', () => {
test('Loading renders successfully', () => {
render(<Loading />)
// Use screen.debug() to see output
expect(screen.getByText('Loading...')).toBeInTheDocument()
expect(() => {
render(<Loading />)
}).not.toThrow()
})

test('Empty renders successfully', async () => {
render(<Empty />)
expect(screen.getByText('Empty')).toBeInTheDocument()
expect(() => {
render(<Empty />)
}).not.toThrow()
})

test('Failure renders successfully', async () => {
render(<Failure error={new Error('Oh no')} />)
expect(screen.getByText(/Oh no/i)).toBeInTheDocument()
expect(() => {
render(<Failure error={new Error('Oh no')} />)
}).not.toThrow()
})

// When you're ready to test the actual output of your component render
// you could test that, for example, certain text is present:
//
// expect(screen.getByText('Hello, world')).toBeInTheDocument()

test('Success renders successfully', async () => {
render(<Success user={standard().user} />)
expect(screen.getByText(/42/i)).toBeInTheDocument()
expect(() => {
render(<Success user={standard().user} />)
}).not.toThrow()
})
})
26 changes: 17 additions & 9 deletions packages/cli/src/commands/generate/cell/__tests__/fixtures/snakeCaseWordCell.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ import { standard } from './UserProfileCell.mock'

describe('UserProfileCell', () => {
test('Loading renders successfully', () => {
render(<Loading />)
// Use screen.debug() to see output
expect(screen.getByText('Loading...')).toBeInTheDocument()
expect(() => {
render(<Loading />)
}).not.toThrow()
})

test('Empty renders successfully', async () => {
render(<Empty />)
expect(screen.getByText('Empty')).toBeInTheDocument()
expect(() => {
render(<Empty />)
}).not.toThrow()
})

test('Failure renders successfully', async () => {
render(<Failure error={new Error('Oh no')} />)
expect(screen.getByText(/Oh no/i)).toBeInTheDocument()
expect(() => {
render(<Failure error={new Error('Oh no')} />)
}).not.toThrow()
})

// When you're ready to test the actual output of your component render
// you could test that, for example, certain text is present:
//
// expect(screen.getByText('Hello, world')).toBeInTheDocument()

test('Success renders successfully', async () => {
render(<Success userProfile={standard().userProfile} />)
expect(screen.getByText(/42/i)).toBeInTheDocument()
expect(() => {
render(<Success userProfile={standard().userProfile} />)
}).not.toThrow()
})
})
26 changes: 17 additions & 9 deletions packages/cli/src/commands/generate/cell/templates/test.js.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ import { standard } from './${pascalName}Cell.mock'

describe('${pascalName}Cell', () => {
test('Loading renders successfully', () => {
render(<Loading />)
// Use screen.debug() to see output
expect(screen.getByText('Loading...')).toBeInTheDocument()
expect(() => {
render(<Loading />)
}).not.toThrow()
})

test('Empty renders successfully', async () => {
render(<Empty />)
expect(screen.getByText('Empty')).toBeInTheDocument()
expect(() => {
render(<Empty />)
}).not.toThrow()
})

test('Failure renders successfully', async () => {
render(<Failure error={new Error('Oh no')} />)
expect(screen.getByText(/Oh no/i)).toBeInTheDocument()
expect(() => {
render(<Failure error={new Error('Oh no')} />)
}).not.toThrow()
})

// When you're ready to test the actual output of your component render
// you could test that, for example, certain text is present:
//
// expect(screen.getByText('Hello, world')).toBeInTheDocument()

test('Success renders successfully', async () => {
render(<Success ${camelName}={standard().${camelName}} />)
expect(screen.getByText(/42/i)).toBeInTheDocument()
expect(() => {
render(<Success ${camelName}={standard().${camelName}} />)
}).not.toThrow()
})
})