Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fast-refresh config to work with storybook #1464

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Move fast-refresh config to work with storybook #1464

merged 2 commits into from
Nov 11, 2020

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Nov 10, 2020

Moves fast-refresh plugin to webpack.common.js as it can be used by storybook.

Storybook doesn't currently use webpack.development.js - we should think about renaming these files to be a little bit more explicit perhaps?

@dac09 dac09 requested a review from peterp November 10, 2020 17:19
@peterp
Copy link
Contributor

peterp commented Nov 10, 2020

@dac09 regarding renaming, what are you thinking about?

@peterp peterp added this to the Next release milestone Nov 10, 2020
@peterp peterp merged commit e3e325a into redwoodjs:main Nov 11, 2020
@dac09 dac09 deleted the try/fast-refresh-in-storybook branch November 11, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dac09 @peterp