forms: Improve typings for errors #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-gql-error-type
branch
7 times, most recently
from
45c9556
to
52df189
Compare
Tobbe
force-pushed
the
tobbe-gql-error-type
branch
from
52df189
to
62d9f4f
Compare
Tobbe
force-pushed
the
tobbe-gql-error-type
branch
from
62d9f4f
to
999821c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<FormError>errorprop was previously typed asany. This PR tries to give it some proper typings.In adapting the code for the types I also made some small implementation changes. I've tried to test things manually, but it's difficult to know what exactly to do to trigger all possible error states. I have, for example, not been able to trigger an error that hits line 78 (That's line 163 the old code)