fix(router): Include queryParams in redirectTo

[dac09]

Fixed #1453

e.g. Say you're going to https://mysite.com/dashboard?param1=something&token=hunter2

It used to redirect to https://mysite.com/login?redirectTo=/dashboard. Now it'll redirect to https://mysite.com/login?redirectTo=/dashboard%3Fparam1%3Dsomething%26token%3Dhunter2

Adds tests for:

• redirectTo
• redirectTo with query params
• Figure out why the test fails (see below) thanks @peterp

---

[dac09]

This test, where the unauthenticated route is home passes, but not the login one. Shouldn't make a difference right?

test('unauthenticated user is redirected including search params', async () => {
  mockAuth(false)
  const TestRouter = () => (
    <Router useAuth={window.__REDWOOD__USE_AUTH}>
      <Route path="/" page={HomePage} name="home" />
      <Route path="/login" page={LoginPage} name="login" />
      <Private unauthenticated="home">
        <Route path="/private" page={PrivatePage} name="private" />
      </Private>
    </Router>
  )
  const screen = render(<TestRouter />)

  // starts on home page
  await waitFor(() => screen.getByText(/Home Page/i))

  // navigate to private page
  // should redirect to login
  act(() => navigate(routes.private({ bazinga: 'yeah' })))

  await waitFor(() => {
    expect(screen.queryByText(/Private Page/i)).toBeNull()
    expect(window.location.pathname).toBe('/')
    expect(window.location.search).toBe(
      `?redirectTo=/private${encodeURIComponent('?bazinga=yeah')}`
    )
    screen.getByText(/Home Page/i)
  })
})

test('authenticated user can access private page', async () => {
  mockAuth(true)
  const TestRouter = () => (
    <Router useAuth={window.__REDWOOD__USE_AUTH}>
      <Route path="/" page={HomePage} name="home" />
      <Private unauthenticated="home">
        <Route path="/private" page={PrivatePage} name="private" />
      </Private>
    </Router>
  )
  const screen = render(<TestRouter />)

  // starts on home page
  await waitFor(() => screen.getByText(/Home Page/i))

  // navigate to private page
  // should not redirect
  act(() => navigate(routes.private()))
  await waitFor(() => {
    expect(screen.getByText(/Private Page/)).toBeTruthy()
    expect(screen.queryByText(/Home Page/)).toBeNull()
  })
})

[dthyresson]

This test, where the unauthenticated route is home passes, but not the login one. Shouldn't make a difference right?

@dac09 Could this recent change have affected the routes?

#1519

[github-actions]

📦 Packages for this PR can be downloaded from
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/create-redwood-app-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-api-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-api-server-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-auth-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-cli-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-core-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-dev-server-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-eslint-config-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-eslint-plugin-redwood-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-forms-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-internal-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-router-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-structure-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-testing-0.21.0-2b81a7b.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1526/redwoodjs-web-0.21.0-2b81a7b.tgz

Install this PR by running yarn rw upgrade --pr 1526:0.21.0-2b81a7b