Add --pr to upgrade command #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-upgrade-pr
branch
from
d985a00
to
4f1a790
Compare
peterp
reviewed
Dec 6, 2020
| requiresArg: true, | ||
| type: 'string', | ||
| }) | ||
| .conflicts('tag', 'pr') |
There was a problem hiding this comment.
Ah nice, I didn't know about this.
Tobbe
force-pushed
the
tobbe-upgrade-pr
branch
from
4f1a790
to
660918e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to install the PR packages we build using the
upgradecli command.Example:
$ yarn rw upgrade --pr 1454:0.21.0-d3b0abdYou specify the PR id (1454 in the example above), the base RW version the PR is based on (0.21.0 above) and the SHA of the commit that was built (d3b0abd).
Yes, it would be nice if you could just do
yarn rw upgrade --pr 1454and get the latest packages built for that PR. But I think we can add that in a future PR. Also, the exact command you need to run is provided as a comment on the PR. So just copy/paste and you're good to go. I think that's easy enough.