Make auto-import pages support .tsx files.

[peterp]

require.resolve did not support .tsx extensions. So, now we're using glob instead. Fast, not recursive. Nice!

TODO:

• Use fixtures directory for tests.
• Remove recursion.
• Make sure consts names are PascalCase.

@dac09 Probably helpful for your work on pre-rendering.

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/create-redwood-app-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-api-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-api-server-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-auth-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-cli-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-core-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-dev-server-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-eslint-config-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-eslint-plugin-redwood-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-forms-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-internal-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-router-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-structure-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-testing-0.23.0-92e63ff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1651/redwoodjs-web-0.23.0-92e63ff.tgz

Install this PR by running yarn rw upgrade --pr 1651:0.23.0-92e63ff

[Tobbe]

require.resolve did not support .tsx extensions.

Because we're using node's resolver, and not TS's, right?

Anyway, this is great stuff! Now we don't have to wrap our tsx pages in a .js wrapper just to auto-load them with the router!

[peterp]

@Tobbe

Because we're using node's resolver, and not TS's, right?

I think this has something to do with require.extensions (which is deprecated), for awhile .ts and .tsx were available, but I'm not sure when they got removed.

I figured that babel's TS module would have registered those in nodejs.

https://nodejs.org/api/modules.html#modules_require_extensions

[dac09]

@peterp this looks great.

Just to check in case there's a simpler way, did you try adding extensions to the Babel preset file? I noticed in my pre-render script that typescript files weren't being loaded until I added the line

extensions: ['.tsx', '.ts', '.jsx', '.js'],

As part of the Babel config.

[peterp]

@dac09 Crazy. I would be very surprised if that's actually something that works. It's something that we've always wanted... because otherwise it has to be specified via the CLI, which is super annoying.

I can't seem to find it in the docs and I found a bunch of issues and an un-merged PR.

If that does work, awesome, but I think this is a better solution, since I removed the recursion and opted for glob instead.