Support Supabase OAuth and Magic Link auth #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
force-pushed
the
dt-supabase-oath-third-party-1537
branch
from
de9ef19
to
4b319f3
Compare
peterp
reviewed
Jan 27, 2021
peterp
reviewed
Jan 27, 2021
peterp
reviewed
Jan 27, 2021
peterp
reviewed
Jan 27, 2021
peterp
reviewed
Jan 27, 2021
|
Looks good to me, I left a few notes about tightening it up with explicitly requiring a provider for magic link instead of trying to figure out if it's magic link based on the props. |
peterp
approved these changes
Jan 27, 2021
peterp
reviewed
Jan 27, 2021
|
@peterp Thanks much for the review! I have submitted the requested changes -- apart from adding "magiclink" as a provider option. See comment note above for rationale. |
Tobbe
reviewed
Jan 27, 2021
Tobbe
approved these changes
Jan 27, 2021
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 1, 2021
…ender-p1 * 'main' of github.com:redwoodjs/redwood: (26 commits) Updating default auth request for acquireTokenSilent add missing env changes to template (redwoodjs#1699) Fix typo in Private Routes Add router as dep to testing. Add auth package to deps. Fixes scaffolded test template (redwoodjs#1690) add new release steps (redwoodjs#1686) update and fix package builds to match lerna build (redwoodjs#1687) Catch everything instead of using the name. Make test-tutorial use template directory. redwood-tools: ignore crwa template Remove exports for RedwoodApolloProvider, use sub-folder. Add build:js script. Updating getToken flow Support Supabase OAuth and Magic Link auth (redwoodjs#1669) Ignore linting template folder in create-redwood-app (redwoodjs#1674) Add a note about publishing. Remove yarn.lock from template. Test bumping packages. Nice! Remove yarn install from script. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Supabase 1.0, it supports OAuth via 'bitbucket' | 'github' | 'gitlab' | 'google' | 'azure' as well as Magic Link passwordless email auth.
resolves #1538
resolves #1537
resolves #1246
addresses #1479
See: https://supabase.io/docs/client/auth-signin
Note that Supabase will support Azure as well, they just have not undated their docs or admin interface to configure the provider.
Authentication doc updates are here: https://github.com/redwoodjs/redwoodjs.com/pull/531
And can be previewed: https://deploy-preview-531--redwoodjs.netlify.app/docs/authentication#supabase
Updates to the playground auth is: redwoodjs/playground-auth#19
Note: this PR also added the restoreAuthState to Netlify as this helped with restoring state after a email magiclink invite signup for both Supabase and Netlify (both GoTrue based).