MockProvider: Wrap children in LocationProvider #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-mock-wrap-locationprovider
branch
2 times, most recently
from
7194322
to
53fa6c7
Compare
Tobbe
commented
Jan 28, 2021
Tobbe
force-pushed
the
tobbe-mock-wrap-locationprovider
branch
2 times, most recently
from
11dedc8
to
1c3579f
Compare
|
@dac09 how about this one for v0.25 vs v0.26? If v0.25, could you then re-ping Peter's review? |
|
Looks clear to me! Will add milestone |
dac09
reviewed
Feb 4, 2021
Tobbe
force-pushed
the
tobbe-mock-wrap-locationprovider
branch
3 times, most recently
from
25d3696
to
16551dc
Compare
Tobbe
commented
Feb 5, 2021
Tobbe
force-pushed
the
tobbe-mock-wrap-locationprovider
branch
from
16551dc
to
4361c60
Compare
Tobbe
force-pushed
the
tobbe-mock-wrap-locationprovider
branch
from
61b25da
to
9e54f78
Compare
|
@peterp This is ready for your review now. And then I can merge it. |
peterp
reviewed
Feb 6, 2021
| @@ -15,6 +15,7 @@ | |||
| "references": [ | |||
| { "path": "../internal" }, | |||
| { "path": "../web" }, | |||
| { "path": "../auth" } | |||
| { "path": "../auth" }, | |||
| { "path": "../router" } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1676