Move deploy and auth from generate to setup #1685
Conversation
|
@dac09 thanks again! I took a quick look. It seems like you are intending for the deprecated command to still run, correct? (Albeit by using the new setup version of the command.) This is my assumption at least. I ran The setup commands did run successfully when called directly. |
|
Hey @thedavidprice, it should error out yes but tell you what the new command is, I haven't made it call the new command automatically - thought it'd be better to just tell the user what the right thing to do is. At some point, we'll take these commands out, I guess, it made sense to me that this gives users the opportunity learn the new behaviour this way. |
|
Happy to still call the command automatically if you prefer though |
|
Got it and makes sense. Maybe two options:
I think option 1 is best, and that we should also go ahead and fully deprecate the |
|
Yep already did the tailwind one! Will get the docs done too - added to list ✅ |
|
@thedavidprice updated docs also. Please do definitely check with your usual tests, as I only ran checks to see if the commands were being triggered (don't have verdaccio running) |
…ender-p1 * 'main' of github.com:redwoodjs/redwood: Fix obejct typo update all contrib (redwoodjs#1710) v0.24.0 Move deploy and auth from generate to setup (redwoodjs#1685) codemod to pass e2e (redwoodjs#1708) Revise the CRWA package README (redwoodjs#1668) Router: Remove prop-types dep router.tsx: redirect spelling Router: Remove __REDWOOD__ global Router: TypeScript rewrite
As requested @thedavidprice
What it does
yarn rw g deploy xxxandyarn rw g auth yyytoyarn rw setup