Azure Active Directory: Updating default auth request for acquireTokenSilent #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me 👍 |
Tobbe
approved these changes
Jan 31, 2021
peterp
approved these changes
Feb 1, 2021
|
No behavior changes here, just internal clarification. So nothing for the changelog. |
| @@ -16,8 +16,8 @@ export const azureActiveDirectory = ( | |||
| logout: (options?) => client.logout(options), | |||
| signup: async (options?) => await client.loginPopup(options), | |||
| getToken: async (options?: any) => { | |||
| const renewIdTokenRequest = options || { | |||
| scopes: [process.env.AZURE_ACTIVE_DIRECTORY_CLIENT_ID], | |||
| const authRequest = options || { | |||
There was a problem hiding this comment.
Hi @jeliasson I see that getToken is being executed from the AuthProvider.tsx without the option to pass any arguments to it, may I know how do I pass in the options argument for the getToken function from my Redwood app? Thank you 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates Azure Active Directory default AuthRequest's
scopeswhen trying to silently acquire a tokenRelated docs
See resolved discussions
https://github.com/redwoodjs/redwoodjs.com/pull/534