[breaking] upgrade Prisma v2.16.0 and replace rw db commands with rw prisma

[thedavidprice]

• Upgrades Prisma v2.16.0
• Deprecates Redwood DB commands
• Add new Redwood Prisma commands
  • Add tests
• Renames template/api/db/seeds.js --> seed.js
• Updated and passing E2E tests

Breaking

This upgrade introduces the new Prisma Migrate:

• breaks yarn rw db commands
• breaks schema.prisma Dyanmic Provider (fully deprecated)
• breaks default deployment command set

Replace @prisma/cli package

This PR also replaces the package @prisma/cli with prisma. See the related Prisma Release Note.

Prisma Release Notes

• v2.16.0
• v2.15.0
• v2.14.0
• v2.13.1
• v2.13.0

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/create-redwood-app-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-api-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-api-server-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-auth-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-cli-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-core-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-dev-server-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-eslint-config-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-eslint-plugin-redwood-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-forms-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-internal-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-router-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-structure-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-testing-0.24.0-9a45a70.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1720/redwoodjs-web-0.24.0-9a45a70.tgz

Install this PR by running yarn rw upgrade --pr 1720:0.24.0-9a45a70

[thedavidprice]

OK, this is most likely going to require upgrading commands at the same time we upgrade Prisma version. I'll coordinate with @peterp directly.

[peterp]

@thedavidprice I've now added the pass through command and the deprecation notices; you can test this by:

1. making sure build:watch is running.
2. running this command:

pwd
~/gh/redwoodjs/redwood/packages/cli
__REDWOOD__CONFIG_PATH=../../__fixtures__/example-todo-main yarn node dist/index.js db up

Deprecation notice
The rw db up command is now deprecated, please try rw prisma up instead.

Migrations are now available via the rw prisma migrate command.

Please view the migration docs

The copy probably needs some work, but it seems to be working nicely. :)

[thedavidprice]

db generate had specific logic for use with Build and Dev commands. I converted to a helper and moved to commands/prisma/generate.js. Perhaps best to move into prisma.js? Suggestions otherwise?

[thedavidprice]

@peterp I have all the commands working now. (Some are more elegant than others.) Input and changes are 100% welcome.

Problems

1. Cannot pass through flags for specific Prisma commands:
   • E.g. yarn rw prisma migrate dev --name migration-name fails because Yargs tries to understand the --name flag
   • Note: I've added an initial hacky workaround for only migrate dev to handle --name automatically and accept --create-only when passed by the user.

Questions

1. Should we add tests to Prisma commands? ((can use previous DB Command tests as reference)
2. We need to figure out the DX for migrate resolve, which potentially is interactive and requests the connection string when run. The other two commands like this are introspect and migrate status:
   • thoughts about how to handle these, either with interactivity or custom options?
   • I don't think it's a priority we need to have custom, interactive support for introspect
3. Should we pass a default Prisma migration name with the option to customize like we did with rw db save? That would be my preference. Had to add this as initial workaround to Problem 1 above.
4. How can we improve --help output? Looking at this again, I'd really like:
   • rw prisma --help to output yarn prisma --help and
   • rw prisma db push --help (for example) to output yarn prisma db push --help

Improvements:

• [priority] currently yargs --help always displays for the top-level command and all other commands; ideally yargs default would only display for the top-level and otherwise display would be Prisma CLI help for specific commands E.g. yarn rw prisma db seed --help
• aliases, E.g. dev for migrate dev or push for db push (probably would need some switchin')

[thedavidprice]

@peterp @cannikin I think I'm over my head regarding the failing tests. My best guess is that Prisma has changed DMMF behavior under the hood without any heads up. Here's a screenshot from the first test that fails:

All roads (that I've traveled) lead back to packages/cli/src/lib/index.js

...
export const getSchemaDefinitions = async () => {
  const schemaPath = path.join(getPaths().api.db, 'schema.prisma')
  const metadata = await getDMMF({
    datamodel: readFile(schemaPath.toString()),
  })

  return metadata
}
...

So, ahem, what is the Prisma Schema DMMF? 🤔

Note: The Scaffold generator does work correctly when manually tested

[thedavidprice]

@cannikin is my HERO 😍