Nhost Auth 1.0 #1725

nunopato · 2021-02-04T01:43:30Z

Adding Nhost as an authentication provider:

Adds Nhost as a authClient
Adds Nhost to the CLI tool

This PR will be updated and finalized in the next couple of days since we have some minor work to do on our SDK.

Some relevant links if you want to know more about Nhost:

Feedback much appreciated!

thedavidprice · 2021-02-04T21:35:08Z

This is amazing @nunopato 🚀 Thank you for getting this started.

I'm setting this as a Draft release. When things are ready for review, just change the status and let us know.

Looping in @dthyresson and @Tobbe, either who can help run point of contact for this.

Lastly, there are two things that could be great next steps beyond this PR:

could you highlight and talk about https://nhost.io in the Redwood Forums? Would be great to know about hosting options for Redwood. Bonus if you have an example Redwood site running on Nhost! https://community.redwoodjs.com
what about adding official deploy target support for Nhost? The DX would be 1) run yarn rw setup deploy-nhost and then 2) yarn rw deploy nhost. Assuming you integrate with GitHub, we could support the effort on your end to build and deploy respective components to CDN and Server. If you're interested, please start a forum post or GH issue and loop me in.

Tobbe · 2021-02-05T07:03:22Z

Thanks for the PR @nunopato. Great start on the auth client!

Looking at the code I'm missing decoder stuff. Can you please take a look at redwood\packages\api\src\auth\decoders\index.ts and see what would be needed for Nhost Auth?

Also please fix the lint errors and then I'll have another look at the code.

Thanks again for getting this started 🙂

nunopato · 2021-02-06T00:49:30Z

@thedavidprice @Tobbe thank you for your comments.

could you highlight and talk about https://nhost.io in the Redwood Forums? Would be great to know about hosting options for Redwood. Bonus if you have an example Redwood site running on Nhost! https://community.redwoodjs.com

Will do! I actually built a very simple example app with the changes from this PR + a Nhost project (Auth+GraphQL) in production. Everything seems to be working just fine.

what about adding official deploy target support for Nhost? The DX would be 1) run yarn rw setup deploy-nhost and then 2) yarn rw deploy nhost. Assuming you integrate with GitHub, we could support the effort on your end to build and deploy respective components to CDN and Server. If you're interested, please start a forum post or GH issue and loop me in.

I assume that by "server components" you mean functions specified in ./api/src/functions, correct?

We support functions (we call it custom API) written in JavaScript/TypeScript and the example app I built has no ./api directory. I am simply pointing the apiProxyPath config to the GraphQL API on Nhost. Let's discuss further how this deployment would look like.

Can you please take a look at redwood\packages\api\src\auth\decoders\index.ts and see what would be needed for Nhost Auth?

Done.

The build is failing because I still need to release a new version (currently in preview) of our SDK. I will do that during the weekend.

Thank you again, really appreciate it.

github-actions · 2021-02-08T11:27:21Z

📦 PR Packages

Click to Show Package Download Links

Install this PR by running yarn rw upgrade --pr 1725:0.25.1-a7222d3

packages/cli/src/commands/setup/auth/providers/nhost.js

nunopato · 2021-02-09T19:29:41Z

@thedavidprice @Tobbe just wanted to let you know that I have marked the PR as ready. An example app can be found here https://github.com/nhost-examples/nhost-redwoodjs and I will post something to the community forum soon depending on your feedback.

Tobbe · 2021-02-10T09:36:40Z

@nunopato Great work! I'll try to take a look tonight.

packages/auth/src/authClients/nhost.ts

packages/api/src/auth/decoders/index.ts

…st-auth-1.0

packages/auth/src/authClients/nhost.ts

Tobbe · 2021-02-11T23:39:21Z

Could you also please write a PR for https://github.com/redwoodjs/redwoodjs.com/blob/main/docs/authentication.md, adding instructions for Nhost?

And we also try to show off our auth implementations in our auth playground, so if you could get an example running there as well, that'd be great :) https://github.com/redwoodjs/playground-auth

Tobbe · 2021-02-11T23:47:13Z

Ohh, and there's also README.md in the auth package. At the end there's a list of all providers, please add nhost there as well

nunopato · 2021-02-12T17:35:07Z

@Tobbe PRs for the playground and redwoodjs.com (docs) can be found here: https://github.com/redwoodjs/redwoodjs.com/pull/562 & redwoodjs/playground-auth#20. The README.md for the Auth package is also updated. Let me know if there is anything else missing.

packages/auth/src/authClients/nhost.ts

…st-auth-1.0

peterp · 2021-02-17T14:27:16Z

packages/auth/src/authClients/nhost.ts

+   * Log In via a OAuth provider also registers the account in case it doesn't exist
+   * @param options.email The user's email address
+   * @param options.password The user's password
+   * @param options.provider One of NhostProvider


Suggested change

* @param options.provider One of NhostProvider

* @param {NHostProvider} options.provider The authentication provider to use

I think we could improve the typings here. I'm not 100% sure of this syntax, but maybe this would work: https://jsdoc.app/tags-typedef.html

Also my comment for the type is lame.

nunopato added 4 commits February 3, 2021 23:46

Add first version of Nhost Auth

caf89e5

Add nhost auth to the CLI

c1e21c9

Remove console.log

54511ff

Remove unnecessary type

d12048b

thedavidprice marked this pull request as draft February 4, 2021 21:35

dthyresson added the topic/auth label Feb 5, 2021

Final adjustments

f476739

nunopato added 3 commits February 6, 2021 00:21

Bump nhost-js-sdk

8ae1d7b

Fix restoreAuthState

b3e4b87

Bump up nhost-js-sdk version

8dfeab5

Merge branch 'main' into nhost-auth-1.0

7413c99

nunopato marked this pull request as ready for review February 8, 2021 11:54

nunopato commented Feb 8, 2021

View reviewed changes

packages/cli/src/commands/setup/auth/providers/nhost.js Outdated Show resolved Hide resolved

Merge branch 'main' into nhost-auth-1.0

ed8fe1d

Merge branch 'main' into nhost-auth-1.0

2a79d07

dthyresson mentioned this pull request Feb 10, 2021

Auth Provider: https://fusionauth.io/ #1731

Closed

Tobbe reviewed Feb 10, 2021

View reviewed changes

packages/auth/src/authClients/nhost.ts Show resolved Hide resolved

Tobbe reviewed Feb 10, 2021

View reviewed changes

packages/api/src/auth/decoders/index.ts Show resolved Hide resolved

nunopato added 3 commits February 11, 2021 17:02

Add AuthClientNhost that implements AuthClient

a9ca0b1

Merge branch 'main' into nhost-auth-1.0

2624509

Merge branch 'nhost-auth-1.0' of github.com:nunopato/redwood into nho…

da6765d

…st-auth-1.0

Tobbe reviewed Feb 11, 2021

View reviewed changes

packages/auth/src/authClients/nhost.ts Outdated Show resolved Hide resolved

nunopato added 2 commits February 12, 2021 15:45

Add Nhost to auth/README.md

1c46f90

Add description for params

3ba3423

Merge branch 'main' into nhost-auth-1.0

7a097d6

Tobbe reviewed Feb 12, 2021

View reviewed changes

packages/auth/src/authClients/nhost.ts Outdated Show resolved Hide resolved

nunopato added 4 commits February 12, 2021 20:41

Add NhostProvider type

d8ef249

Merge branch 'nhost-auth-1.0' of github.com:nunopato/redwood into nho…

117427d

…st-auth-1.0

Remove empty line

185fb92

Remove skipFetchCurrentUser

8b3bd10

Tobbe approved these changes Feb 17, 2021

View reviewed changes

Merge branch 'main' into nhost-auth-1.0

e4e3f99

Tobbe mentioned this pull request Feb 17, 2021

[v0.26.0] Add Nhost to Auth Docs redwoodjs/redwoodjs-com-archive#562

Merged

peterp reviewed Feb 17, 2021

View reviewed changes

peterp approved these changes Feb 17, 2021

View reviewed changes

Merge branch 'main' into nhost-auth-1.0

a7222d3

thedavidprice merged commit 601b33a into redwoodjs:main Feb 22, 2021

thedavidprice added this to the next release milestone Feb 22, 2021

thedavidprice added next release docs labels Feb 22, 2021

rishabhpoddar mentioned this pull request Feb 24, 2021

Add integration with RedwoodJS supertokens/supertokens-core#129

Closed

6 tasks

Tobbe mentioned this pull request Apr 22, 2021

Add Nhost redwoodjs/playground-auth#59

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nhost Auth 1.0 #1725

Nhost Auth 1.0 #1725

nunopato commented Feb 4, 2021 •

edited

Loading

thedavidprice commented Feb 4, 2021

Tobbe commented Feb 5, 2021

nunopato commented Feb 6, 2021

github-actions bot commented Feb 8, 2021 •

edited

Loading

nunopato commented Feb 9, 2021 •

edited

Loading

Tobbe commented Feb 10, 2021

Tobbe commented Feb 11, 2021

Tobbe commented Feb 11, 2021

nunopato commented Feb 12, 2021

peterp Feb 17, 2021

peterp Feb 17, 2021

peterp Feb 17, 2021

	* @param options.provider One of NhostProvider
	* @param {NHostProvider} options.provider The authentication provider to use

Nhost Auth 1.0 #1725

Nhost Auth 1.0 #1725

Conversation

nunopato commented Feb 4, 2021 • edited Loading

thedavidprice commented Feb 4, 2021

Tobbe commented Feb 5, 2021

nunopato commented Feb 6, 2021

github-actions bot commented Feb 8, 2021 • edited Loading

📦 PR Packages

nunopato commented Feb 9, 2021 • edited Loading

Tobbe commented Feb 10, 2021

Tobbe commented Feb 11, 2021

Tobbe commented Feb 11, 2021

nunopato commented Feb 12, 2021

peterp Feb 17, 2021

Choose a reason for hiding this comment

peterp Feb 17, 2021

Choose a reason for hiding this comment

peterp Feb 17, 2021

Choose a reason for hiding this comment

nunopato commented Feb 4, 2021 •

edited

Loading

github-actions bot commented Feb 8, 2021 •

edited

Loading

nunopato commented Feb 9, 2021 •

edited

Loading