Specify node_env before running build web

[dac09]

Small change to make sure all downstream loaders/plugins for webpack receive NODE_ENV as production when running yarn rw build web

This takes care of a lot of weird issues that arise, such as Tailwind not minifying (unless you're lucky, and your build environment has NODE_ENV production by default).

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/create-redwood-app-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-api-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-api-server-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-auth-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-cli-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-core-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-dev-server-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-eslint-config-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-eslint-plugin-redwood-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-forms-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-internal-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-router-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-structure-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-testing-0.24.0-1f6258a.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1755/redwoodjs-web-0.24.0-1f6258a.tgz

Install this PR by running yarn rw upgrade --pr 1755:0.24.0-1f6258a

[dac09]

I know I blocked merging this, but I have to resolve conflicts in build.js anyway. Gonna merge!

[razzeee]

Would this explain, why accessing NODE_ENV on a deployed server always seems to return production instead of what we've set in NODE_ENV, or should that still be loaded from env when we run yarn rw serve?

https://redwoodjs.com/docs/environment-variables#where-does-redwood-load-my-environment-variables isn't very clear if it really applies to all yarn rw commands I think.

[dac09]

Would this explain, why accessing NODE_ENV on a deployed server always seems to return production instead of what we've set in NODE_ENV, or should that still be loaded from env when we run yarn rw serve?

Correct - NODE_ENV will always be overridden to production when you build and serve.

[razzeee]

might be worth documenting on the env var docs