Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix dm install duplicate console output #1798

Conversation

dthyresson
Copy link
Contributor

@dthyresson dthyresson commented Feb 16, 2021

continues #1787

In the v0.25 point release, we saw during dataMigrate install duplicated output like:

 ✔ Creating dataMigrations directory...
  ✔ Adding RW_DataMigration model to schema.prisma...
  ⠦ Create db migration...
    One more thing...
  ✔ Creating dataMigrations directory...
  ✔ Adding RW_DataMigration model to schema.prisma...
  ⠏ Create db migration...
  ✔ Creating dataMigrations directory...
  ✔ Adding RW_DataMigration model to schema.prisma...
  ⠸ Create db migration...
    One more thing...
Prisma schema loaded from db/schema.prisma
Datasource "DS": SQLite database "dev.db" at "file:./dev.db"
  ✔ Creating dataMigrations directory...
  ✔ Adding RW_DataMigration model to schema.prisma...
  ✔ Create db migration...
  ✔ Next steps:
    Don't forget to apply your migration when ready:
     yarn rw prisma migrate dev

This removes the stdio: 'inherit', from the save() which was added a few days ago to resolve some interactivity issues w/ the prisma command (but may have introduced this issue and is not needed).

Needs testing by @thedavidprice

@dthyresson dthyresson marked this pull request as draft February 16, 2021 03:32
@github-actions
Copy link

@thedavidprice
Copy link
Contributor

Success! And it handles error output just fine.

Screen Shot 2021-02-15 at 7 42 27 PM

I'm running into more Prisma errors with the migrate dev--create-only command than I've found with other commands. It seems to me they're still working out the kinks with this one and it not capable at this time of detecting or resolving drift.

@thedavidprice thedavidprice marked this pull request as ready for review February 16, 2021 03:45
@thedavidprice thedavidprice merged commit 73a8efe into redwoodjs:main Feb 16, 2021
@thedavidprice thedavidprice added this to the next release milestone Feb 16, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Feb 16, 2021
…ender-p1

* 'main' of github.com:redwoodjs/redwood:
  v0.25.1
  Attempt to fix dm install duplicate console output (redwoodjs#1798)
  dataMigrate install uses prisma migrate command (redwoodjs#1787)
  Hotfix: Use inherit to allow interactivity in yarn rw prisma (redwoodjs#1790)
  Show errors coming from Prisma
@dthyresson dthyresson deleted the dt-data-migrate-duplicate-console-output branch December 23, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants