-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch create-redwood-app template to TypeScript #1810
Conversation
63d8a62
to
aa1ab68
Compare
@peterp Does that mean that you "need" to use typescript when using Redwood? Or will it remain optional? |
@jvanbaarsen 100% optional. It'll always be JavaScript by default. |
It looks like the only thing missing is to solve the conflicts, right? |
adding @dac09 as a reviewer to confirm changes he made to CRWA template are reflected in the final changes here |
Just needs:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
9c4e341
to
3dab340
Compare
@dac09 I'm sorry, I rewrote the You can now do something like this:
/cc @thedavidprice |
…-e2e-tests * 'main' of github.com:redwoodjs/redwood: Bump @apollo/client from 3.3.7 to 3.3.11 (redwoodjs#1923) Switch create-redwood-app template to TypeScript (redwoodjs#1810) Bump @graphql-tools/merge from 6.2.7 to 6.2.10 (redwoodjs#1910) Adds resolution to template, to prevent module duplication in web/node_modules (redwoodjs#1933) Update service generator to use Prisma namespace (redwoodjs#1853) Make storybook configurable in a redwood app (redwoodjs#1828)
We would like to give people the option to generate a TypeScript project. This PR will allow people to create both a JS and a TS RedwoodJS project. JavaScript will always be the default.