Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backticks #1826

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Remove backticks #1826

merged 2 commits into from
Feb 23, 2021

Conversation

adriatic
Copy link
Contributor

I propose this change for uniformity reason so that anyone searching for "single-quoted" strings would not miss this one. There is a chance that the author had a good reason for avoiding "double-quoted" strings - in that case, please ignore this PR.

I propose this change for uniformity reason so that anyone searching for "single-quoted" strings would not miss this one. There is a chance that the author had a good reason for avoiding "double-quoted" strings - in that case, please ignore this PR.
@github-actions
Copy link

github-actions bot commented Feb 21, 2021

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/create-redwood-app-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-api-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-api-server-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-auth-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-cli-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-core-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-dev-server-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-eslint-config-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-eslint-plugin-redwood-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-forms-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-internal-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-prerender-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-router-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-structure-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-testing-0.25.1-d6fa8dc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1826/redwoodjs-web-0.25.1-d6fa8dc.tgz

Install this PR by running yarn rw upgrade --pr 1826:0.25.1-d6fa8dc

@thedavidprice
Copy link
Contributor

Looks good to me. Thanks @adriatic 🚀

@thedavidprice thedavidprice added this to the next release milestone Feb 23, 2021
@thedavidprice thedavidprice merged commit 40e145d into redwoodjs:main Feb 23, 2021
dac09 added a commit to dac09/redwood that referenced this pull request Feb 23, 2021
…late-and-auth-setup-tests

* 'main' of github.com:redwoodjs/redwood:
  [TS] Add types to flash, clean up some logic (redwoodjs#1824)
  Remove backticks (redwoodjs#1826)
  Add Gravatar to the list of Tom's accomplishments (redwoodjs#1813)
  Don't open storybook when --open=false is given (redwoodjs#1795)
  Passthrough error codes on cli failures (redwoodjs#1791)
  E2E: if path to project given, use the installed packages (redwoodjs#1837)
  Add Cypress Step6 Test (redwoodjs#1780)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants