Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logger Readme destination param in transport examples #2055

Merged

Conversation

dthyresson
Copy link
Contributor

The params in the Datadog and Logflare example code for the Logger README had incorrect params.

This PR fixes that so there are both options and destination params (not the destination is a part of options).

@github-actions
Copy link

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/create-redwood-app-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-api-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-api-server-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-auth-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-cli-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-core-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-dev-server-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-eslint-config-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-eslint-plugin-redwood-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-forms-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-internal-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-prerender-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-router-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-structure-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-testing-0.27.1-8a936f2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2055/redwoodjs-web-0.27.1-8a936f2.tgz

Install this PR by running yarn rw upgrade --pr 2055:0.27.1-8a936f2

@dthyresson dthyresson self-assigned this Mar 22, 2021
@dthyresson dthyresson merged commit 9e2cca7 into redwoodjs:main Mar 22, 2021
@thedavidprice thedavidprice added this to the next release milestone Mar 22, 2021
@dthyresson dthyresson deleted the dt-logger-readme-transport-params-fixes branch December 23, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants