Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes formatDateTime helper when field is optional and value is empty #2072

Merged
merged 3 commits into from Mar 23, 2021

Conversation

cannikin
Copy link
Member

Closes #1995

@github-actions
Copy link

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/create-redwood-app-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-api-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-api-server-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-auth-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-cli-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-core-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-dev-server-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-eslint-config-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-eslint-plugin-redwood-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-forms-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-internal-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-prerender-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-router-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-structure-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-testing-0.27.1-aa293b2.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/2072/redwoodjs-web-0.27.1-aa293b2.tgz

Install this PR by running yarn rw upgrade --pr 2072:0.27.1-aa293b2

@cypress
Copy link

cypress bot commented Mar 23, 2021



Test summary

11 0 1 0Flakiness 0


Run details

Project RedwoodJS Framework
Status Passed
Commit 53aa58d ℹ️
Started Mar 23, 2021 8:28 PM
Ended Mar 23, 2021 8:31 PM
Duration 02:38 💡
OS Linux Ubuntu - 20.04
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cannikin cannikin merged commit 7f21240 into main Mar 23, 2021
@cannikin cannikin deleted the rc-empty-datetime-format-fix branch March 23, 2021 20:34
@cannikin cannikin added bug/confirmed We have confirmed this is a bug topic/forms labels Mar 23, 2021
@thedavidprice thedavidprice added this to the next release milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/forms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.27 DateField error
2 participants