Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI test only] Cypress E2E Windows Runner #2227

Closed
wants to merge 8 commits into from
Closed

[CI test only] Cypress E2E Windows Runner #2227

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
915e842
remove runners for testing
thedavidprice Apr 6, 2021
c2c6ba7
remove runners for testing
thedavidprice Apr 6, 2021
d10fa19
use bash explicitly
thedavidprice Apr 6, 2021
bcc1390
no dev server; does Cypress start?
thedavidprice Apr 7, 2021
5c195b2
re-add rw dev step
thedavidprice Apr 7, 2021
c7a2b41
Update .github/workflows/e2e.yaml
thedavidprice Apr 7, 2021
15bb07b
use cy.task 🤮
thedavidprice Apr 8, 2021
6d25ff8
add cy.task plugin
thedavidprice Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/dependabot.yml
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions .github/workflows/build-eslint-jest.yaml
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions .github/workflows/create_pr_artifact.yaml
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
if: github.repository == 'redwoodjs/redwood'
strategy:
matrix:
os: ['ubuntu-latest']
os: ['windows-latest']
node-version: ['14']
fail-fast: true
runs-on: ${{ matrix.os }}
Expand All @@ -30,18 +30,20 @@ jobs:

- name: Create a temporary directory
id: createpath
shell: bash
run: |
project_path=$(mktemp -d -t redwood.XXXXXX)
echo "::set-output name=project_path::$project_path"

- name: Create a RedwoodJS app
shell: bash
run: ./tasks/run-e2e ${{ steps.createpath.outputs.project_path }} --no-start

- name: Start server in background
shell: bash
run: yarn rw dev &
working-directory: ${{ steps.createpath.outputs.project_path }}
thedavidprice marked this conversation as resolved.
Show resolved Hide resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tobbe can you help me diagnose why this would fail on Windows bash? Actually, what would be ideal is to instead use scripts for each of these steps that work on Powershell. Possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try something like this:

run: |
  echo "${{ steps.createpath.outputs.project_path }}"
  cd "${{ steps.createpath.outputs.project_path }}"
  yarn rw dev &

It'll tell us

  1. Do we even get a valid path to this step?
  2. Does it look right?
  3. Does it help to start the server when standing in the directory as opposed to trying to set cwd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tobbe well, that worked. Question: what would the Powershell version of this command be (if possible)?

Next step: can I have the Cypress action run with Powershell... gonna go check some docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo and cd are both commands PS understands. So if it's GH that does the "${{ steps.createpath.outputs.project_path }}" substitution to a proper value, it should all just work in PS as well. But if GH is doing some kind of injection of variables into the shell, and it's actually bash that does the substitution then I don't know.


- name: Cypress run
uses: cypress-io/github-action@v2
env:
Expand Down
21 changes: 0 additions & 21 deletions .github/workflows/netlify-build.yaml
View file
Open in desktop

This file was deleted.

47 changes: 0 additions & 47 deletions .github/workflows/publish-npm-canary.yaml
View file
Open in desktop

This file was deleted.

82 changes: 0 additions & 82 deletions .github/workflows/publish_pr_packages.yaml
View file
Open in desktop

This file was deleted.