fix failing CI: upgrade @types packages, apollo-server-lambda #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
thedavidprice
changed the title
thedavidprice
commented
Jun 4, 2021
| @@ -22,6 +22,7 @@ export const mockedAPIGatewayProxyEvent: APIGatewayProxyEvent = { | |||
| apiKey: null, | |||
| apiKeyId: null, | |||
| caller: null, | |||
| clientCert: null, | |||
There was a problem hiding this comment.
@dac09 It seems the @types/aws-lambda package required this and was failing during build.
If CI passes, I'm going to merge. But please review this and update as needed in future PR.
|
🚀 |
thedavidprice
added a commit
that referenced
this pull request
Jun 7, 2021
* rebuild yarn.lock * upgrade types packages * update api/.../fixtures type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing E2E CLI build command due to type issue related to the /api package and
@types/aws-lamdbaandapollo-server-lambda.packages/api/src/functions/fixtures/apiGatewayProxyEvent.fixture.ts