Switch router and web from esm to cjs. #290
Conversation
|
Assuming I should take this for a spin locally, test Jest, and parts of the tutorial… Any other thoughts about kicking the tires? |
|
@thedavidprice I'm testing it right now - there are some problems that I'm busy fixing. |
packages/cli/src/commands/generate/templates/cell/test.js.template
Outdated
Show resolved
Hide resolved
| version "0.2.1" | ||
| resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.2.1.tgz#827ba4e7593464e7c221e8c5bed930904ee2c455" | ||
| integrity sha512-GY8fANSrTMfBVfInqJAY41QkOM+upUTytK1jZ0c8+3HdHrJxBJ3rF5i9moClXTE8uUSnUo8cAsCoxDXvSY4DHg== | ||
| minimist@0.0.8: |
There was a problem hiding this comment.
Security issue here —> we need to have >v0.2.1
Can you fix before merge?
|
|
||
| minimist@^1.2.5: | ||
| minimist@^1.1.1, minimist@^1.1.3, minimist@^1.2.0: |
There was a problem hiding this comment.
This one for security issue too —> we need to have >v1.2.5
Can you fix before merge?
| version "1.2.5" | ||
| resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.5.tgz#67d66014b66a6a8aaa0c083c5fd58df4e4e97602" | ||
| integrity sha512-FM9nNUYrRBAELZQT3xeZQ7fmMOBg6nWNmJKTcgsJeaLstP/UODVpGsr5OhXhhXg6f+qtJ8uiZ+PUxkDWcgIXLw== | ||
|
|
||
| minimist@~0.0.1: |
There was a problem hiding this comment.
Gah, seems like all these are being overwritten. Background, I had to manually update in lock file because these are sub-dependencies. Was definitely a pain to figure out but easy now.
It’s trivial for me to fix after this is merged, by the way. Just let me know.
…ules-to-cjs Switch router and web from esm to cjs.
No description provided.