Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass undefined name to RHF get() #3038

Merged
merged 5 commits into from Jul 15, 2021

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 13, 2021

RHF's get() method can't handle undefined names being passed as the second argument. So this PR makes sure we only call that function if we actually have a name.

Fixes #3037

@redwoodjs-bot redwoodjs-bot bot added this to New issues in Current-Release-Sprint Jul 13, 2021
@jtoar jtoar moved this from New issues to Ready to merge in Current-Release-Sprint Jul 15, 2021
@thedavidprice thedavidprice merged commit c2d9ea8 into redwoodjs:main Jul 15, 2021
Current-Release-Sprint automation moved this from Ready to merge to Done Jul 15, 2021
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jul 15, 2021
thedavidprice pushed a commit that referenced this pull request Jul 15, 2021
* Don't pass undefined name to RHF get()

Fixes #3037

* form.test.tsx format

* revert FieldError get

Co-authored-by: Dominic Saadi <32992335+jtoar@users.noreply.github.com>
Co-authored-by: jtoar <dominic.saadi@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Label without name causes runtime error
4 participants