New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbAuth Vercel Fix #3309
Merged
Merged
dbAuth Vercel Fix #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cannikin
added
bug/confirmed
We have confirmed this is a bug
topic/auth
release:breaking
This PR is a breaking change
labels
Aug 30, 2021
dac09
approved these changes
Aug 31, 2021
Verified that deploy works to Netlify as well: https://jolly-bohr-d8f980.netlify.app/ |
LGTM! Thanks Lord Cannakin! |
That's Cann i kin! 😃 |
dac09
pushed a commit
that referenced
this pull request
Sep 1, 2021
Co-authored-by: Rob Cameron <rob.cameron@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug/confirmed
We have confirmed this is a bug
release:breaking
This PR is a breaking change
topic/auth
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues that Vercel was blowing up on:
isBase64Encoded
to true, and you can't decode an empty stringFixing these introduced another issue, where
getToken
returned an empty string which a client call forgetUserMetadata
interpreted as there being a user logged in and so would call the GraphQL endpoint forgetCurrentUser
, which then returned a 500. This is patched as well.(Potential) Breaking Change
Serverless functions may already wait for async code to complete before returning (this hasn't been an issue in dev or a serverfull deployment). But in case they don't, anyone already using dbAuth should update their
api/src/functions/auth.js
to include anawait
on the final line of code:Before:
After: