Swap mergeSchemas with makeExecutableSchema #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the title says it all!
Motivation in #333
Unfortunately what @peterp mentioned in #333 (comment) didn't fly; just swapping out
apollo-server-lambda
forgraphql-tools-fork
didn't work. It seems likegraph-tools-fork
is improving on the seemingly abandonedgraphql-tools
, but not (yet) on custom directive support formergeSchemas
.What does however support custom directives is
makeExecutableSchema
. In order to use this I needed to merge thetypeDefs
, and the only/quickest/cleanest way I could find to do this is usingmerge-graphql-schemas
, the second package mentioned by @peterp.Using this PR you can pass
schemaDirectives
inmakeMergedSchemas
like so: