Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for #379, yarn rw db introspect #385

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Conversation

Jaikant
Copy link
Contributor

@Jaikant Jaikant commented Apr 3, 2020

This is my first PR, and I picked an issue based on the label. Hopefully no one else was looking at it!

@cannikin
Copy link
Member

cannikin commented Apr 3, 2020

@Jaikant thanks so much for the PR! Check out the result of those failing build steps below, looks like it might just be a couple quick syntax tweaks.

@Jaikant
Copy link
Contributor Author

Jaikant commented Apr 4, 2020

@cannikin I also included lint in the package.json of the cli package, the reason for me missing it the first time around.

Copy link
Contributor

@thedavidprice thedavidprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comment about packages/cli/package.json

Thanks!

@Jaikant
Copy link
Contributor Author

Jaikant commented Apr 7, 2020

@cannikin @thedavidprice ok. Pushed the changes. This is how the help looks (I don't like the help text taking two lines, but probably ok?)

Jais-MacBook-Pro:prisma jai$ yarn rw db help
yarn run v1.22.4
$ /Users/jai/redwood/aol-chat-support/node_modules/.bin/rw db help
rw <command>

Commands:
  rw db down           Migrate your database down.
  rw db generate       Generate the Prisma client.
  rw db introspect     Introspect your database and generate the models in
                       api/prisma/schema.prisma (overwrites existing models).
  rw db save [name..]  Create a new migration.
  rw db seed           Seed your database with test data.
  rw db up             Generate the Prisma client and apply migrations.

Options:
  --help     Show help                                                 [boolean]
  --version  Show version number                                       [boolean]
✨  Done in 1.60s.

@peterp peterp merged commit d5886c3 into redwoodjs:master Apr 10, 2020
@thedavidprice
Copy link
Contributor

FYI: I should have caught this earlier, but we just updated to Prisma 2.0 Beta and switched the command line use of prisma2 to prisma. I’ll make a quick update here.

Thanks again!

mohsen1 pushed a commit to mohsen1/redwood that referenced this pull request Apr 12, 2020
@thedavidprice thedavidprice added this to the unassigned-version milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants