Add iniital yarn build to CONTRIBUTING.md #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it an overkill to have a |
|
@satyarohith I think if it were more complicated we could add that command, but I kinda like that people who are contributing are now introduced to the concept of |
|
@jtoar Thanks! |
mohsen1
pushed a commit
to mohsen1/redwood
that referenced
this pull request
Apr 12, 2020
…ributing.md Add iniital yarn build to CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md didn't explicitly say to run
yarn buildafter cloningredwoodjs/redwoodand runningyarn install, causing files necessary for using the cli locally, such asmain.jsinredwood/internal, to not exist. This PR stems from a discussion on discourse: https://community.redwoodjs.com/t/guide-on-redwood-package-development/135/3?u=dom.