Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for local Postgres and connection pooling. #422

Merged

Conversation

cball
Copy link
Contributor

@cball cball commented Apr 11, 2020

Based on discussion in redwoodjs/redwoodjs.com#87, I've added two docs to the docs section.

The first gives more information around Connection Pools, and includes relevant links to recommended providers. (Rendered)

The second documents how to setup Postgres locally, and how to have Redwood create/migrate the new database. (Rendered)

@thedavidprice
Copy link
Contributor

Looks great, @cball I read through each for clarity and grammar/spelling check, which is all good for each file.

I did check each link. However, I did not run through examples or confirm specific instructions work for the cases given. Assuming you’ve done this locally and confirmed.

@thedavidprice thedavidprice merged commit 30431ae into redwoodjs:master Apr 13, 2020
@cannikin
Copy link
Member

@thedavidprice Do we want these to get their own standalong pages on redwoodjs.com? We'd just need to add to the build script over there.

@thedavidprice
Copy link
Contributor

Boom!
redwoodjs/redwoodjs.com#88

@cball
Copy link
Contributor Author

cball commented Apr 13, 2020

Awesome! @thedavidprice it looks like we may need to remove the # .env comment from the code section in the docs... it seems to be tripping up whatever is parsing the markdown into html and assuming it should be part of the TOC.

image

@cball
Copy link
Contributor Author

cball commented Apr 13, 2020

PR opened: #425

@cball cball deleted the cb-local-pg-and-connection-pool-docs branch April 13, 2020 19:59
@thedavidprice thedavidprice added this to the unassigned-version milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants