Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe generator postfix #4261

Merged
merged 10 commits into from
Jan 28, 2022
Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 24, 2022

Adding yargs coercion on the name arg to trim the name of the command from the end of name.
The Cell, Layout and Page generators now remove their own name from the end of the passed name argument
So if you use the layout generator and the name specified ends with Layout, that'll get trimmed off. (Because the layout generator will always add Layout as a prefix on the name)

Fixes #3913

@Tobbe Tobbe added release:feature This PR introduces a new feature release:fix This PR is a fix labels Jan 24, 2022
@thedavidprice thedavidprice removed the release:fix This PR is a fix label Jan 24, 2022
@Tobbe Tobbe force-pushed the tobbe-generator-dedupe-postfix branch from 6d26cf4 to 716d8dd Compare January 25, 2022 05:35
@Tobbe Tobbe force-pushed the tobbe-generator-dedupe-postfix branch from bfb92ba to 3017ca9 Compare January 25, 2022 10:22
@Tobbe Tobbe requested a review from cannikin January 25, 2022 23:31
@Tobbe Tobbe enabled auto-merge (squash) January 28, 2022 06:49
@Tobbe Tobbe merged commit b5cdd75 into redwoodjs:main Jan 28, 2022
@jtoar jtoar added this to the next-release milestone Jan 28, 2022
@Tobbe Tobbe deleted the tobbe-generator-dedupe-postfix branch January 28, 2022 09:23
@thedavidprice thedavidprice modified the milestones: next-release, v0.44.0 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

Don't duplicate the prefix if it is passed into a generator
4 participants