-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rw deploy render
redundant api processes causing server to exceed mem limit
#4278
fix rw deploy render
redundant api processes causing server to exceed mem limit
#4278
Conversation
rw deploy render
redundant api processes that exceed memrw deploy render
redundant api processes causing server to exceed mem limit
Ready 🚀 |
Nice work @thedavidprice! Can't wait to take this for a spin on my own Render deploy! |
Awesome work @thedavidprice! I may not have time to check it out this weekend, but I will on Monday or Tuesday for sure. cc @SEANDOUGHTY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just have to merge and take it for a spin
re:
I'm unable to do this due to this bug #4352 Skipping so I can get this in. |
fixes #4271
TODO:
rw-api-server
binary; userw-server api
insteadRender Deploy API Server < 500MB Mem
Now uses imports from the api-server package to programatically start fastify without spawning or running another RW CLI command (which was the root cause of multiple running processes). Total process mem < 225MB.
![Screen Shot 2022-01-28 at 11 06 27 PM](https://user-images.githubusercontent.com/2951/151651513-ff64836f-efee-4b74-a138-c714267d25ad.png)
![Screen Shot 2022-01-28 at 11 10 23 PM](https://user-images.githubusercontent.com/2951/151651538-628e834c-f006-4208-ada7-3b99c580c6e5.png)
run
yarn rw deploy render api
process memory
Additionally I cleaned up a few things with the
setup deploy render
anddeploy render
commands.api-server console output
The console outputs for
apiServerHandler
,webServerHandler
,bothServerHandler
weren't consitent and didn't always make sense to me. I've updated them accordingly:bothServerHandler
akayarn rw serve
apiServerHandler
akayarn rw serve api
webServerHandler
akayarn rw serve web
New
api-server
bin in `package/api-server/package.jsonPreviously the
serve api
process could be run via bin, e.g.yarn rw-api-server
. It made sense to me to add a bin that would handle running api, web, or both.This is now possible via
yarn rw-server
:both
, takesapi
orweb