Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold: Enable all tests again and update snapshots #4299

Merged
merged 2 commits into from
Jan 30, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 30, 2022

Remove accidentally committed describe.only in a test file.
Needed to also update the snapshots. Now that we're running all tests again some of the snapshots had become stale.

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) action/add-to-release labels Jan 30, 2022
@dthyresson dthyresson requested review from dthyresson and removed request for cannikin January 30, 2022 02:00
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tobbe Tobbe merged commit 623284c into redwoodjs:main Jan 30, 2022
@Tobbe Tobbe deleted the tobbe-scaffold-test-no-only branch January 30, 2022 02:01
@jtoar jtoar added this to the next-release milestone Jan 30, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v0.44.0 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

None yet

4 participants