Sort package.jsons #4309
Merged
Sort package.jsons #4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-sort-package-jsons
branch
from
30e3b0a
to
3c800ad
Compare
thedavidprice
requested changes
Jan 31, 2022
There was a problem hiding this comment.
Yes to these changes overall.
re: sort-package-json
I agree we should add this properly to CI, which means we need to run it locally, too, and seems a candidate to add to ./package.json
Because I'm seeing more PRs created that have initial issues with dedupe, constraints (still needs fix), and (now), sort-package-json, what do you think about the following:
- need more helpful output during CI about how to resolve if one of those checks failed
- could use a tool/script locally to run before submitting PR; e.g.
yarn pr-prepthat runsyarn dedupe && yarn constraints && yarn sort-package-jsonOr something like that - ... ?
Making sense? Reactions?
jtoar
force-pushed
the
ds-sort-package-jsons
branch
from
2b2c166
to
f57fd40
Compare
|
@thedavidprice Working through some ideas; will update later today. |
|
@thedavidprice Think I've got this into a mergable state: https://s.tape.sh/mwLz7dnP. |
There was a problem hiding this comment.
Nice! This is a great idea (and CI addition). It's fine by me as is, but a couple suggestions:
- See my comment here about console.log in the context of GH Workflow run
- What do you think about updating the CONTRIBUTING.md to mention
yarn check? - Reminder as next step to look into why
yarn constraintsisn't catching^. (See this PR comment from earlier today Pin dependencies #4317)
I'll attemp to use the same structure to create a kind of "Actions Helper" for the make directory step in #4266
thedavidprice
approved these changes
Jan 31, 2022
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 1, 2022
…ize-jest-config * 'main' of github.com:redwoodjs/redwood: (46 commits) update contributing content (redwoodjs#4325) Upgrade yarn to 3.1.1 (redwoodjs#3919) Sort package.jsons (redwoodjs#4309) Update dependency esbuild to v0.14.16 (redwoodjs#4322) Add explanation and docs link in generated tests (redwoodjs#4218) Update dependency webpack to v5.68.0 (redwoodjs#4315) Update dependency esbuild to v0.14.15 (redwoodjs#4321) Update dependency cypress to v9.4.1 (redwoodjs#4319) Update dependency @typescript-eslint/parser to v5.10.2 (redwoodjs#4318) Pin dependencies (redwoodjs#4317) Pull proper keys for Yarn and npm (redwoodjs#4313) Add missing deps to @redwoodjs/forms package.json (redwoodjs#4310) Update dependency @typescript-eslint/eslint-plugin to v5.10.2 (redwoodjs#4314) Tweak release script (redwoodjs#4312) Update dependency @graphql-codegen/typescript-operations to v2.2.3 (redwoodjs#4311) Update dependency vscode-languageserver-textdocument to v1.0.4 (redwoodjs#4308) Update dependency copy-webpack-plugin to v10.2.4 (redwoodjs#4307) Update storybook monorepo to v6.4.17 (redwoodjs#4306) Update release script (redwoodjs#4305) Update dependency msw to v0.36.8 (redwoodjs#4301) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking at the framework's
package.jsons a lot more and since they're all sorted differently, bouncing between them is harder than it has to be. So this PR uses sort-package-json to make things consistent across workspaces:We can configure it and/or add it to CI.
Also here's docs on
yarn workspaces foreachandyarn dlx(which is equivalent tonpx):