Support for undefined as a value for service validators
#4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realStandal
changed the title
undefined as a value for service validators
|
@cannikin is this one you can take a look at? |
cannikin
approved these changes
Feb 22, 2022
|
Awesome, and thanks for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3979
CC: @jtoar
Summary
Passing
undefinedto one of the service validators will now function as though having never defined the validator at all.Letting:
Be functionally equivalent to:
As such, it also adds a test which ensures the above (
validate('foo', {})) always equates to being "do not validate/throw".