dbAuth: Prevent futureExpiresDate from changing when referenced in tests #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Mar 13, 2022
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Mar 15, 2022
…d into feat/auth-checks-smoke-test * 'feat/auth-checks-smoke-test' of github.com:dac09/redwood: fix(deps): update dependency esbuild to v0.14.27 (redwoodjs#4755) chore(deps): update dependency cypress to v9.5.2 (redwoodjs#4754) chore(deps): update dependency @types/lodash to v4.14.180 (redwoodjs#4751) fix(deps): update typescript-eslint monorepo to v5.15.0 (redwoodjs#4752) fix(deps): update dependency esbuild to v0.14.26 (redwoodjs#4747) Setup futureExpiresDate in constructor (redwoodjs#4742) chore(deps): update dependency @clerk/clerk-sdk-node to v2.9.10 (redwoodjs#4746) fix(deps): update dependency eslint-plugin-react to v7.29.4 (redwoodjs#4745)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by @Tobbe here: #4735
We think this is a better overall solution as it effectively memoizes the value so that it doesn't change on subsequent calls (tests or not).