-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Radio Field #479
Conversation
Thanks so much for this @vikash-eatgeek! So you've tested this locally and forms work as expected? If you leave required as |
When required is I have tested it locally; it works as expected. Consistent with other field's behavior. 😎 |
Thanks so much! Let me know if you want to do the checkbox input next. ;) |
@cannikin thanks for reviewing and merging the changes. FYI: Great videos on redwoodJS. My friends and I are learning redwoodjs from your tutorials. We have an everyday calendar meeting called |
That’s awesome! Let me know if there’s anything I can do to make them easier to learn from! For now the videos just take you through the tutorial but we’ll have more soon. Check out the Videos section of the site, there’s an additional one on there from @mojombo that shows how to add a page loading indicator on slow connections: https://redwoodjs.com/videos <https://redwoodjs.com/videos>
… On Apr 29, 2020, at 3:04 PM, Vikash ***@***.***> wrote:
@cannikin <https://github.com/cannikin> thanks for reviewing and merging the changes.
I was thinking about that. Afterall I am becoming pro in form fields. I would be more than happy to do the tick the checkboxes. thanks!!
FYI: Great videos on redwoodJS. My friends and I are learning redwoodjs from your tutorials. We have an everyday calendar meeting called Climbing Redwood for learning together. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#479 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAACLEHBLKLI26RRG6HYE3RPCQATANCNFSM4MSYNSEA>.
|
The videos are great. I have watched the page loading indicator video on twitter. till now, everything is great. I will surely give feedback if something comes up. |
Hi gents! Must say the code is great. But the included update to docs just makes me 😍 |
Thanks, @thedavidprice. I just followed the code/readme structure in the codebase. 😄 |
Closes #464
This PR is the implementation of the
radio
text field in the redwood framework.The default
required
attribute isfalse
for the radio field. If the user wants to have requiredtrue
for a group of radio fields, the user has to pass the propvalidation={{ required: true }}
for all the radio fields/buttons.To check how
react-hook-form
handles the creation of the radio fields, It can be checked here. They also do{ required: true }
for all the radio fields in a group. :)