Consider not running CI on changes to docs #4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for redwoodjs-docs canceled. 🔨 Explore the source changes: 50324c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/62345ccd1509400008366760 |
|
I have to make a lot of changes to docs at the moment so I'm going to merge this to expedite the process, but will bring up for a more thorough discussion next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring CI to pass for changes to docs seems a little excessive. We definitely want some CI to run, but probably just some kind of check that confirms that the docs site still deploys. Opening this up for discussion! Here's the docs on the workflow syntax I'm using: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths