Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Yoga / Rework multi and non-multi query string param handling when building request #4883

Merged
merged 3 commits into from Mar 22, 2022

Conversation

dthyresson
Copy link
Contributor

Seeing

invalid json response body at https://undefined/api/graphql?query=%7Bpost%28id%3A1%29%7Btitle%7D%7D&query=%7Bpost%28id%3A1%29%7Btitle%7D%7D&query=%7B&query=p&query=o&query=s&query=t&query=%28&query=i&query=d&query=%3A&query=1&query=%29&query=%7B&query=t&query=i&query=t&query=l&query=e&query=%7D&query=%7D reason: Unexpected token e in JSON at position 0

Notice the many query per character.

This PR reworks the way the multiValueQueryStringParameters and gives that precedence of the queryString to avoid duplicates.

@netlify
Copy link

netlify bot commented Mar 22, 2022

✅ Deploy Preview for redwoodjs-docs canceled.

🔨 Explore the source changes: 0974013

🔍 Inspect the deploy log: https://app.netlify.com/sites/redwoodjs-docs/deploys/623a13addc7e0900085aab60

@dthyresson dthyresson added the release:fix This PR is a fix label Mar 22, 2022
@dthyresson dthyresson merged commit ad91bf6 into redwoodjs:main Mar 22, 2022
@dthyresson dthyresson deleted the dt-multi-headers-yoga branch March 22, 2022 18:48
@jtoar jtoar added this to the next-release milestone Mar 22, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v0.50.0 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

None yet

3 participants