Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended VS Code extensions when setting up tailwindcss #5099

Conversation

zygopleural
Copy link
Contributor

This should solve #5089

@netlify
Copy link

netlify bot commented Apr 9, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit 642d69e
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/625ed725b900d00008827986
😎 Deploy Preview https://deploy-preview-5099--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jtoar jtoar added topic/cli release:feature This PR introduces a new feature labels Apr 9, 2022
@zygopleural
Copy link
Contributor Author

FYI @jtoar I tried testing this locally, but project:sync doesn't seem to be working for me 🤔

@dac09
Copy link
Collaborator

dac09 commented Apr 11, 2022

@zygopleural because you're using the nous account - I can't update the branch, could you please merge in the latest main? Thanks :)

@dac09 dac09 self-assigned this Apr 11, 2022
@dac09
Copy link
Collaborator

dac09 commented Apr 11, 2022

Thanks @zygopleural - needs a fix on the linting errors, but also when running this I get:

  ✖ Adding recommended VS Code extensions...
    → _path.default.existsSync is not a function
_path.default.existsSync is not a function

I think maybe its meant to be fs.existsSync ?

Copy link
Collaborator

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested

@zygopleural zygopleural force-pushed the add-tailwindcss-recommended-vscode-extensions branch from 049007e to 2cd8a3d Compare April 11, 2022 09:19
@zygopleural
Copy link
Contributor Author

Thanks @zygopleural - needs a fix on the linting errors, but also when running this I get:

  ✖ Adding recommended VS Code extensions...
    → _path.default.existsSync is not a function
_path.default.existsSync is not a function

I think maybe its meant to be fs.existsSync ?

huh yeah maybe, I'm sure there was a reason I didn't use fs, maybe was just tired

@dac09
Copy link
Collaborator

dac09 commented Apr 12, 2022

Just the lint errors left, and the writeFileSync suggestion @zygopleural - thanks!

@zygopleural
Copy link
Contributor Author

Just the lint errors left, and the writeFileSync suggestion @zygopleural - thanks!

🥲

@zygopleural
Copy link
Contributor Author

Just the lint errors left, and the writeFileSync suggestion @zygopleural - thanks!

Just got round to it @dac09

@zygopleural zygopleural force-pushed the add-tailwindcss-recommended-vscode-extensions branch from bbe8b77 to 4313202 Compare April 12, 2022 22:34
@jtoar jtoar requested a review from dac09 April 13, 2022 14:42
@zygopleural zygopleural force-pushed the add-tailwindcss-recommended-vscode-extensions branch from 4313202 to 642d69e Compare April 19, 2022 15:37
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zygopleural! The TailwindCSS experience is amazing with that extension 🚀

@jtoar jtoar merged commit 261b1dc into redwoodjs:main Apr 19, 2022
@jtoar jtoar added this to the next-release milestone Apr 19, 2022
@zygopleural
Copy link
Contributor Author

Thanks @zygopleural! The TailwindCSS experience is amazing with that extension 🚀

yeah so much better!

@thedavidprice thedavidprice modified the milestones: next-release, v1.2.0 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature topic/cli
Projects
No open projects
Status: Done
4 participants