-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move @types/react resolution to Redwood packages with @types/react-dom dep #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
thedavidprice
changed the title
Dsp move react dom types resolution
move @types/react resolution to Redwood packages with @types/react-dom dep
Apr 14, 2022
CI and GitPod checks out (expected because GitPod uses rwfw). Merging to try canary package on local test project. |
Good call @thedavidprice! This works locally for me 🎉 |
Ha! 🙂 |
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate approach (and experiment) to #5112, which I've reverted in this PR.
If Yarn will respect resolutions set at the root of our packages that include
@types/react-dom
, then we do not need to require projects to manage the resolution themselves.The only way to test this is to publish packages. Once CI passes, I'll merge and try the canary on a fresh TS project and run
yarn why
. If it works, we'll keep this. If it doesn't, I'll revert and we'll fall back to #5112.🤞
-- me