Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @types/react resolution to Redwood packages with @types/react-dom dep #5165

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

thedavidprice
Copy link
Contributor

This is an alternate approach (and experiment) to #5112, which I've reverted in this PR.

If Yarn will respect resolutions set at the root of our packages that include @types/react-dom, then we do not need to require projects to manage the resolution themselves.

The only way to test this is to publish packages. Once CI passes, I'll merge and try the canary on a fresh TS project and run yarn why. If it works, we'll keep this. If it doesn't, I'll revert and we'll fall back to #5112.

🤞

The dependency of my dependency is my enemy

-- me

@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 4ca19de
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/6257a627f2084c00083ce16a

@thedavidprice thedavidprice changed the title Dsp move react dom types resolution move @types/react resolution to Redwood packages with @types/react-dom dep Apr 14, 2022
@thedavidprice thedavidprice added the release:fix This PR is a fix label Apr 14, 2022
@thedavidprice
Copy link
Contributor Author

CI and GitPod checks out (expected because GitPod uses rwfw). Merging to try canary package on local test project.

@thedavidprice thedavidprice merged commit cd24cd0 into main Apr 14, 2022
@thedavidprice thedavidprice deleted the dsp-move-react-dom-types-resolution branch April 14, 2022 04:58
@jtoar jtoar added this to the next-release milestone Apr 14, 2022
@Tobbe
Copy link
Member

Tobbe commented Apr 14, 2022

Good call @thedavidprice! This works locally for me 🎉

@thedavidprice
Copy link
Contributor Author

thedavidprice commented Apr 14, 2022

Screen Shot 2022-04-13 at 10 11 46 PM

🚀

Note: react-syntax-highlighter is a Storybook dep and not involved in our tsc dep resolutions

@Tobbe
Copy link
Member

Tobbe commented Apr 14, 2022

Ha! 🙂

@thedavidprice
Copy link
Contributor Author

@Tobbe Same'sies!

This whole dep mess was just driving me nuts. Huge thank you for all the work you did on the Codemods and everything in #5112

I honestly gave this PR a less than 50% chance of working. Sometimes we get lucky, I guess...

thedavidprice added a commit that referenced this pull request Apr 14, 2022
…m dep (#5165)

* Revert "RW projects: Add resolutions for @types/react 17 (#5112)"

This reverts commit 7a1deb5.

* add  @types/react resolution to react-dom packages

* fix yarn check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

None yet

3 participants