Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds function generator #517

Merged
merged 5 commits into from
May 6, 2020
Merged

Adds function generator #517

merged 5 commits into from
May 6, 2020

Conversation

cannikin
Copy link
Member

@cannikin cannikin commented May 5, 2020

Closes #516

@cannikin cannikin requested a review from peterp May 5, 2020 23:57
peterp
peterp approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME! 🍰

@peterp
Copy link
Contributor

peterp commented May 6, 2020

I'm wondering about the nam: yarn rw g function has overloaded meaning... but I can't really think of something better.

@cannikin
Copy link
Member Author

cannikin commented May 6, 2020

Yeah there was a spot where I had to use the name functionGenerator to avoid that clash. The other usage is functions so I think it's okay? 😬

@cannikin cannikin merged commit 5212e2c into master May 6, 2020
@cannikin cannikin deleted the rc-function-generator branch May 6, 2020 16:44
@cannikin cannikin added this to the next release milestone May 6, 2020
@peterp peterp mentioned this pull request May 10, 2020
Closed
jmreidy pushed a commit to jmreidy/redwood that referenced this pull request May 19, 2020
@cannikin
Adds function generator (redwoodjs#517)
3f249a8 
* Adds function generator

Closes redwoodjs#516

* Remove comment, old code

* Adds test for updated templateForComponentFile

* Update test path

* Try another path

Co-authored-by: Rob Cameron <rob.cameron@fastmail.com>
jmreidy pushed a commit to jmreidy/redwood that referenced this pull request May 30, 2020
@cannikin
Adds function generator (redwoodjs#517)
4919c79 
* Adds function generator

Closes redwoodjs#516

* Remove comment, old code

* Adds test for updated templateForComponentFile

* Update test path

* Try another path

Co-authored-by: Rob Cameron <rob.cameron@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Add generator for functions
2 participants
@cannikin @peterp