-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NamesCell reload after deleting item #519
Conversation
Use pluralCamelName in place of hardcoded string when performing refetchQuery in delete handler
Great catch, thanks! I’ll merge as soon as it’s not in Draft! Might be a couple of test fixtures that need updates? |
For sure! The draft is a bookmark for me to double check that it works and come back here :) |
I'm thinking the test fixtures should work out of the box since they expect 'POSTS' to be generated anyway. I'm having trouble testing that the scaffolding works myself however. I've followed the contribution guide as well as the Additionally, I get the following error when running the scaffold command on a fresh project who has had a model generated and saved with the appropriate db commands (save, up).
|
^^ If you're referring to Jest and ESLint tests, your 100% correct. However, although we've done a ton of work to date, the
CLI development is a tricky, messy beast. You'll have to use the "Local Package Emulation" process. And each time you make changes to the package, you need to re-run the process:
^^ are you running this attempting to use lastest 'master' branch packages? If so, again you'll need to use the "Local Package Emulation" process. The reason is due to how newly added npm packages added to the RW Framework are not locally included automatically when trying to use the local RW Framework packages in a local RW App. That's the likely cause for this error `Error: Cannot find module 'humanize-string' |
Following the local package reg instructions I've been able to test and confirm that my fix works :) Fix reproduction steps:
|
AWESOME! Good to merge? |
GTG! |
Thanks! |
Use pluralCamelName in place of hardcoded string when performing refetchQuery in delete handler
Use pluralCamelName in place of hardcoded string when performing refetchQuery in delete handler
Use pluralCamelName in place of hardcoded string when performing refetchQuery in delete handler
Fixes #518