Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray @types/react resolution from @redwoodjs/core #5197

Merged
merged 2 commits into from
Apr 16, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Apr 16, 2022

Follow up to #5192. In that PR, we removed resolutions in @redwoodjs/forms, @redwoodjs/testing and @redwoodjs/web, but left it in @redwoodjs/core. @thedavidprice was there a reason the one in @redwoodjs/core was left in? Yarn seems to totally ignore it (this output is from yarn install):

➤ YN0000: ┌ Project validation
➤ YN0057: │ @redwoodjs/core: Resolutions field will be ignored
➤ YN0000: └ Completed

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Apr 16, 2022
@jtoar jtoar self-assigned this Apr 16, 2022
@netlify
Copy link

netlify bot commented Apr 16, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 78a2be7
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/625b04a66a4cc90008f62edf

@thedavidprice
Copy link
Contributor

clean miss on my part. thanks for having my back!

@thedavidprice thedavidprice merged commit 6aaad8a into main Apr 16, 2022
@thedavidprice thedavidprice deleted the ds-rm-stray-@types/react-res branch April 16, 2022 18:02
@jtoar jtoar added this to the next-release milestone Apr 16, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v1.2.0 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants