Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scenario filenames with multiple dots #5248

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Support scenario filenames with multiple dots #5248

merged 4 commits into from
Apr 21, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Apr 19, 2022 •
edited

This PR adds support for scenario files with multiple dots in the "name" part of the file name.
We expect to see something like contacts.scenarios.ts. If you had con.tacts.scenarios.ts instead, that'll now work as well.

Fixes #5222

@netlify
Copy link

netlify bot commented Apr 19, 2022 •
edited

✅ Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 5c36fe8
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62610eb193c2ac0008d33d22

@Tobbe Tobbe mentioned this pull request Apr 19, 2022
Closed
@Tobbe Tobbe added release:fix This PR is a fix topic/testing labels Apr 19, 2022
@Tobbe Tobbe marked this pull request as ready for review April 19, 2022 21:53
@Tobbe Tobbe requested a review from jtoar April 19, 2022 21:53
@Tobbe
Copy link
Member Author

Tobbe commented Apr 19, 2022

@jtoar Could you review this please? For some reason I couldn't test this with rufus. Just get
image
And no tests run.

But it works fine on GitPod.

@jtoar
Copy link
Contributor

jtoar commented Apr 21, 2022

Thanks @Tobbe! Reviewing now. And rwfw definitely needs some TLC. That should be my next priority

jtoar
jtoar approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jtoar jtoar merged commit 34acbb5 into redwoodjs:main Apr 21, 2022
@jtoar jtoar added this to the next-release milestone Apr 21, 2022
@Tobbe Tobbe deleted the tobbe-jest-scenario-dots branch April 21, 2022 09:02
@thedavidprice thedavidprice modified the milestones: next-release, v1.2.0 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar approved these changes

Assignees

@Tobbe Tobbe

Labels
release:fix This PR is a fix topic/testing
Projects
No open projects
Release
Status: Done
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Scenarios don't support filenames with an extra dot: .
3 participants
@Tobbe @jtoar @thedavidprice