Remove git reset
in canary workflow
#5324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--no-git-reset
lerna flag to thepublish:canary
command. This is so that we can use the version later in another job. This PR also moves thepublish:canary
command to the workflow, removing it from the package.json. @thedavidprice let me know if you'd like to undo this last change.Using this PR as a summary of some of the changes I've made to the canary and release candidate workflows:
git describe
was needed)Note that when I make changes to CI, I usually test them out on my fork, but it's pretty difficult to test if a release workflow works on a fork. So that's why I've had to do a bit of trial and error here.