Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git reset in canary workflow #5324

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Apr 24, 2022

This PR adds the --no-git-reset lerna flag to the publish:canary command. This is so that we can use the version later in another job. This PR also moves the publish:canary command to the workflow, removing it from the package.json. @thedavidprice let me know if you'd like to undo this last change.

Using this PR as a summary of some of the changes I've made to the canary and release candidate workflows:

  • e00d421 - the "main" PR, refactors the workflows
  • 15751da - debugging (forgot to checkout the repo)
  • 6f00933 - debugging (you can't use secrets in composite actions)
  • d6bc218 - debugging (mistakenly thought git describe was needed)
  • 682acb4 debugging (finally realized I was checking out the repo twice)
  • 64c18ef - add emoji to status
  • c1b3a46 - debugging (missing quotes)

Note that when I make changes to CI, I usually test them out on my fork, but it's pretty difficult to test if a release workflow works on a fork. So that's why I've had to do a bit of trial and error here.

@jtoar jtoar added topic/ops-&-contributing-dx release:chore This PR is a chore (means nothing for users) labels Apr 24, 2022
@jtoar jtoar self-assigned this Apr 24, 2022
@netlify
Copy link

netlify bot commented Apr 24, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit 6fa8ab5
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/6267396a257a08000823e41b

@jtoar jtoar mentioned this pull request Apr 25, 2022
4 tasks
@thedavidprice thedavidprice merged commit 8805544 into main Apr 26, 2022
@thedavidprice thedavidprice deleted the ds-rm-git-reset-in-canary-workflow branch April 26, 2022 00:14
@jtoar jtoar added this to the next-release milestone Apr 26, 2022
jtoar added a commit that referenced this pull request Apr 26, 2022
* Rm `git reset` in canary workflow

* Split over multiple lines

* Update .github/workflows/publish-release-candidate.yml

Co-authored-by: David Price <thedavid@thedavidprice.com>
@jtoar jtoar modified the milestones: next-release, v1.2.0 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users) topic/ops-&-contributing-dx
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants