Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert children into array to do array things. #547

Merged
merged 2 commits into from
May 15, 2020
Merged

Convert children into array to do array things. #547

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dce483
Convert children into array to do array things.
peterp May 15, 2020
75e8fdb
Merge branch 'master' into pp-fix-private-router-bug
peterp May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/router/src/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const RouterImpl = ({
// Find `Private` components, mark their children `Route` components as private,
// and merge them into a single array.
const privateRoutes =
children
React.Children.toArray(children)
.filter((child) => child.type === Private)
.map((privateElement) => {
// Set `Route` props
Expand Down