Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cell plugin not handling default and named export #601

Conversation

gfpacheco
Copy link
Contributor

No description provided.

@gfpacheco
Copy link
Contributor Author

gfpacheco commented May 25, 2020

@peterp the CI is breaking because of my intentional "breaking" test. I guess I should just remove that, what do you think?

I just wanted to make sure the plugin would still process it as a Cell if export const QUERY was there. But I'm not sure that's needed.

Another option would be making the eslint ignore fixture files.

@peterp
Copy link
Contributor

peterp commented May 26, 2020

I just wanted to make sure the plugin would still process it as a Cell if export const QUERY was there. But I'm not sure that's needed.

I think that's a good call, you could disable ESLint with a pragma mark for the specific file.
By adding: /* eslint-disable */ to the top of the file.

I guess we could disable it for all fixtures, but then we would loose the ability to automatically format them. (Since we format via ESLint.)

@gfpacheco
Copy link
Contributor Author

I think that's a good call, you could disable ESLint with a pragma mark for the specific file.
By adding: /* eslint-disable */ to the top of the file.

That didn't work, I tried disabling the whole file and just one line, but eslint kept complaining about the double default export error.

@peterp
Copy link
Contributor

peterp commented May 27, 2020

Cool, cool, cool - Thanks for that. I'll see if I can figure that out later.

@peterp peterp merged commit c94ec22 into redwoodjs:pp-abort-cell-hoc-with-default-export May 27, 2020
@peterp peterp added this to the next release milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants