-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added full qualified path and mockServiceWorker.js to webpack file copy globOptions #6117
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f23b73e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
thanks @standup75! this fix makes a lot of sense to me. quick aside afaik this will "break" this hacky workaround I am using to deploy a built Storybook to Netlify in the example-storybook repo ( redwoodjs/example-storybook#117 ). But that is totally ok, because this hack should not really be necessary. We have been needing to fix how we pass in mocks / the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @standup75, and thanks for reviewing @virtuoushub! I tried a few other options like baseNameMatch
and nothing seemed to be working like you said, so it seems like fully-qualified paths is the way to go indeed.
fixes #5225
Also fixes the fact that the
README.md
was getting copied although it was not the intentionAs noted in this comment there seem to be limitation in copy-webpack-plugin and it only worked with fully qualified path.
Also tried to set
globOptions.gitignore
to true as this seems to be what we wanted formockServiceWorker.js
but it didn't work and would not solve the problem with theREADME.md
file