Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full qualified path and mockServiceWorker.js to webpack file copy globOptions #6117

Merged
merged 5 commits into from
Aug 7, 2022

Conversation

standuprey
Copy link
Contributor

@standuprey standuprey commented Aug 3, 2022

fixes #5225

Also fixes the fact that the README.md was getting copied although it was not the intention

As noted in this comment there seem to be limitation in copy-webpack-plugin and it only worked with fully qualified path.

Also tried to set globOptions.gitignore to true as this seems to be what we wanted for mockServiceWorker.js but it didn't work and would not solve the problem with the README.md file

@nx-cloud
Copy link

nx-cloud bot commented Aug 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f23b73e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for redwoodjs-docs canceled.

Name Link
🔨 Latest commit f23b73e
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62ef2180ee93ef000833ef17

@virtuoushub
Copy link
Collaborator

virtuoushub commented Aug 4, 2022

thanks @standup75! this fix makes a lot of sense to me.


quick aside afaik this will "break" this hacky workaround I am using to deploy a built Storybook to Netlify in the example-storybook repo ( redwoodjs/example-storybook#117 ). But that is totally ok, because this hack should not really be necessary. We have been needing to fix how we pass in mocks / the msw config to our Storybook config for a while so hopefully this helps accelerate that work.

See also ( #5269 -> #5534 )

@Tobbe Tobbe assigned virtuoushub and unassigned Tobbe Aug 4, 2022
@jtoar jtoar self-assigned this Aug 6, 2022
@jtoar jtoar added the release:fix This PR is a fix label Aug 6, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @standup75, and thanks for reviewing @virtuoushub! I tried a few other options like baseNameMatch and nothing seemed to be working like you said, so it seems like fully-qualified paths is the way to go indeed.

@jtoar jtoar enabled auto-merge (squash) August 7, 2022 02:00
@jtoar jtoar merged commit 4ea0bc4 into redwoodjs:main Aug 7, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 7, 2022
@jtoar jtoar modified the milestones: next-release, v3.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mockServiceWorker.js created by storybook is copied into web dist
4 participants