Tutorial 4.1: Update lib/auth code & remove warning about non-existent TS error (fixed via #5856, shipped in v2.1) #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit aeb18a2. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Philzen
force-pushed
the
update-auth.ts-tutorial
branch
from
e6bd0c3
to
fc2ddd3
Compare
Tobbe
reviewed
Aug 8, 2022
Philzen
force-pushed
the
update-auth.ts-tutorial
branch
from
fc2ddd3
to
896cdc3
Compare
Tobbe
reviewed
Aug 8, 2022
Philzen
force-pushed
the
update-auth.ts-tutorial
branch
from
265e4c3
to
08fac71
Compare
Tobbe
requested changes
Aug 8, 2022
Philzen
force-pushed
the
update-auth.ts-tutorial
branch
from
08fac71
to
2e35076
Compare
This was fixed via redwoodjs#5856 and shipped as part of Redwood 2.1
This should not be cause for panic, it's merely information :)
Philzen
force-pushed
the
update-auth.ts-tutorial
branch
from
2e35076
to
aeb18a2
Compare
Tobbe
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this hasn't been updated a while :)
Actually, on second look that code is even dysfunctional b/c
hasRole(roles)call inrequiredAuthwould have failed.Also took the liberty of degrading
:::cautionto:::info, as there really is no need to be "alarmed" about anything, we're merely providing some context.