chore(cli): Add additional tests for sdl generator #6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5dd30be. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 14 targets
Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs canceled.
|
dac09
added
release:chore
dthyresson
approved these changes
Aug 10, 2022
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Aug 15, 2022
…9/redwood into fix/cell-prerender-graphql-fallback * 'fix/cell-prerender-graphql-fallback' of github.com:dac09/redwood: Stylistic suggestions Leverage PROJECT_CWD to set cwd in yarn 3 bin "proxies" (redwoodjs#6199) chore(cli): Add additional tests for sdl generator (redwoodjs#6200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional tests to prevent regression fixed in #6195
Why?
When we run sdl... internally we also generate service files. We had a regression where the scenario file wasn't being generated - these tests just make sure we don't regress on it again!