Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show authentication errors in <FormError> #621

Merged
merged 2 commits into from
May 29, 2020
Merged

Show authentication errors in <FormError> #621

merged 2 commits into from
May 29, 2020

Conversation

Terris
Copy link
Contributor

@Terris Terris commented May 29, 2020

Fixes #568

  • Adds a standard auth error message to generated auth.js file
  • Adds a fallback root message if rootMessage is empty: "Something went wrong."
  • Adds conditional rendering to the Form error messages list.
  • Fixes a minor spacing issue in the styles.

@cannikin cannikin merged commit afd8133 into redwoodjs:master May 29, 2020
@cannikin
Copy link
Member

Thanks for this!

@thedavidprice thedavidprice added this to the next release milestone May 29, 2020
@Terris Terris mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cannikin cannikin cannikin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.1-2
Development

Successfully merging this pull request may close these issues.

Show authentication errors in <FormError>
3 participants
@Terris @cannikin @thedavidprice